]> Savannah Git Hosting - gnulib.git/commit
diffseq: remove TOO_EXPENSIVE heuristic
authorPaul Eggert <eggert@cs.ucla.edu>
Mon, 24 Feb 2014 00:16:31 +0000 (16:16 -0800)
committerPaul Eggert <eggert@cs.ucla.edu>
Mon, 24 Feb 2014 00:17:09 +0000 (16:17 -0800)
commit67b00f9a6c5cc08c9c667822b21e18a59b318dd5
treee0d4027da59f3e7b4e7ffc363a5f8cb6af2ee969
parent26e2108a3b6bad235316f36d68365f5a9ee9f634
diffseq: remove TOO_EXPENSIVE heuristic

Problem with diffutils reported by Vincent Lefevre in
<http://bugs.gnu.org/16848>.  The simplest solution is to remove
the TOO_EXPENSIVE heuristic that I added to GNU diff in 1993.
Although appropriate for circa-1993 hardware, these days the heuristic
seems to be more trouble than it's worth.
* lib/diffseq.h: Modernize citations.
(struct context): Remove member too_expensive.
All uses changed.
(struct partition): Remove members lo_minimal, hi_minimal.
All uses changed.
(diag, compareseq): Remove arg find_minimal.  All uses changed.
(diag): Remove the TOO_EXPENSIVE heuristic that I added back in
1993 to make 'diff' run faster (but not as well) on large inputs.
These days, computers are fast enough that it's typically better
to run slower but more accurately.
* lib/fstrcmp.c: Remove duplicate comment.
* lib/fstrcmp.c (strcmp_bounded):
* lib/git-merge-changelog.c (compute_differences):
Adjust to diffseq.h changes.
ChangeLog
lib/diffseq.h
lib/fstrcmp.c
lib/git-merge-changelog.c