]> Savannah Git Hosting - gnulib.git/commit
stdio: Don't redefine gets when using C++
authorJonathan Perkin <jperkin@joyent.com>
Thu, 4 Jun 2015 11:10:34 +0000 (12:10 +0100)
committerEric Blake <eblake@redhat.com>
Fri, 5 Jun 2015 16:25:01 +0000 (10:25 -0600)
commitd6176702c3ffb6c56e6620397470e1b3bd540b10
tree60f6b6653eef2d1df9d1aa4e261b311158055de6
parente4f783014dc6a8c0da9e60a6f958ec6df73df1ce
stdio: Don't redefine gets when using C++

We've hit this failure a few times in pkgsrc with packages which embed gnulib,
an example being the latest gnutls:

  ../../src/gl/stdio.h:1034:1: error: 'char* gets(char*)' conflicts with a previous declaration
   _GL_WARN_ON_USE (gets, "gets is a security hole - use fgets instead");
   ^

  /opt/tools/gcc49/lib/gcc/x86_64-sun-solaris2.11/4.9.2/include-fixed/iso/stdio_iso.h:259:14: note: previous declaration 'char* std::gets(char*)'
   extern char *gets(char *);
                ^

Full build log is here:

  http://us-east.manta.joyent.com/pkgsrc/public/reports/upstream-trunk32/20150602.2233/gnutls-3.3.15/build.log

We've fixed it a few different ways over time:

  https://github.com/joyent/pkgsrc/blob/joyent/release/2015Q1/devel/m4/patches/patch-lib_stdio.in.h
  https://github.com/joyent/pkgsrc/blob/joyent/release/2015Q1/math/octave/patches/patch-libgnu_stdio.in.h
  https://github.com/joyent/pkgsrc/blob/joyent/release/2015Q1/security/gnutls/patches/patch-gl_stdio.in.h

but the cleanest fix appears to be the last, so I am proposing it here for
inclusion upstream.

Message-Id: <20150604111034.GG66573@joyent.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
ChangeLog
lib/stdio.in.h