]> Savannah Git Hosting - gnulib.git/commitdiff
dfa-tests: test for today's invalid-merge fix
authorJim Meyering <meyering@fb.com>
Sun, 1 Nov 2020 15:39:49 +0000 (07:39 -0800)
committerJim Meyering <meyering@fb.com>
Sun, 1 Nov 2020 17:12:59 +0000 (09:12 -0800)
* tests/test-dfa-invalid-merge.sh: New file.
* modules/dfa-tests (Files): Add it.
(TESTS): Add it.

ChangeLog
modules/dfa-tests
tests/test-dfa-invalid-merge.sh [new file with mode: 0755]

index 25c386e6c344351855106ce245480b3f4c00bf38..4c69371817ab2ce7dec485c8885bf607ab003d42 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,10 @@
+2020-11-01  Jim Meyering  <meyering@fb.com>
+
+       dfa-tests: test for today's invalid-merge fix
+       * tests/test-dfa-invalid-merge.sh: New file.
+       * modules/dfa-tests (Files): Add it.
+       (TESTS): Add it.
+
 2020-11-01  Norihiro Tanaka  <noritnk@kcn.ne.jp>
 
        dfa: retain sequences of similar nodes in optimization
index 2775ccbbf98126b30336c303776ca9604f97acf3..878e18d6d8af9119bcb06f2ff2d739c1424b260a 100644 (file)
@@ -2,6 +2,7 @@ Files:
 tests/test-dfa-match.sh
 tests/test-dfa-match-aux.c
 tests/test-dfa-invalid-char-class.sh
+tests/test-dfa-invalid-merge.sh
 
 Depends-on:
 stdio
@@ -14,6 +15,7 @@ configure.ac:
 Makefile.am:
 TESTS += \
   test-dfa-invalid-char-class.sh \
+  test-dfa-invalid-merge.sh \
   test-dfa-match.sh
 
 check_PROGRAMS += test-dfa-match-aux
diff --git a/tests/test-dfa-invalid-merge.sh b/tests/test-dfa-invalid-merge.sh
new file mode 100755 (executable)
index 0000000..4b5783b
--- /dev/null
@@ -0,0 +1,31 @@
+#!/bin/sh
+# The DFA matcher would wrongly convert a regular expression like
+# a+a+a to a+a, thus possibly reporting a false match.
+# Introduced in v0.1-2111-g4299106ce
+
+# Copyright 2020 Free Software Foundation, Inc.
+
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <https://www.gnu.org/licenses/>.
+
+. "${srcdir=.}/init.sh"; path_prepend_ ../src
+
+# Add "." to PATH for the use of test-dfa-match-aux.
+path_prepend_ .
+
+fail=0
+
+LC_ALL=C returns_ 0 ${CHECKER} test-dfa-match-aux 'x+x+x+' xx > out 2>&1
+compare /dev/null out || fail=1
+
+Exit $fail