+2019-10-09 Paul Eggert <eggert@cs.ucla.edu>
+
+ regex: avoid copying of uninitialized storage
+ * config/srclist.txt: Comment out regcomp.c temporarily.
+ * lib/regcomp.c (build_charclass_op, create_tree) [! (GCC_LINT||lint)]:
+ Initialize even when not checking for lint, as the behavior is
+ arguably undefined otherwise and Coverity warns about it.
+
2019-10-06 Bruno Haible <bruno@clisp.org>
access tests: Fix test failure when run as root.
$LIBCSRC malloc/scratch_buffer_set_array_size.c lib/malloc
# Temporarily newer in Gnulib than in glibc.
#$LIBCSRC include/intprops.h lib
-$LIBCSRC posix/regcomp.c lib
+#$LIBCSRC posix/regcomp.c lib
$LIBCSRC posix/regex.c lib
$LIBCSRC posix/regex.h lib
$LIBCSRC posix/regex_internal.c lib
Idx alloc = 0;
#endif /* not RE_ENABLE_I18N */
reg_errcode_t ret;
- re_token_t br_token;
bin_tree_t *tree;
sbcset = (re_bitset_ptr_t) calloc (sizeof (bitset_t), 1);
#endif
/* Build a tree for simple bracket. */
-#if defined GCC_LINT || defined lint
- memset (&br_token, 0, sizeof br_token);
-#endif
- br_token.type = SIMPLE_BRACKET;
- br_token.opr.sbcset = sbcset;
+ re_token_t br_token = { .type = SIMPLE_BRACKET, .opr.sbcset = sbcset };
tree = create_token_tree (dfa, NULL, NULL, &br_token);
if (__glibc_unlikely (tree == NULL))
goto build_word_op_espace;
create_tree (re_dfa_t *dfa, bin_tree_t *left, bin_tree_t *right,
re_token_type_t type)
{
- re_token_t t;
-#if defined GCC_LINT || defined lint
- memset (&t, 0, sizeof t);
-#endif
- t.type = type;
+ re_token_t t = { .type = type };
return create_token_tree (dfa, left, right, &t);
}