]> Savannah Git Hosting - gnulib.git/commitdiff
vasnprintf: pacify clang 3.5.0
authorPaul Eggert <eggert@cs.ucla.edu>
Tue, 3 Mar 2015 15:48:40 +0000 (07:48 -0800)
committerPaul Eggert <eggert@cs.ucla.edu>
Tue, 3 Mar 2015 15:49:03 +0000 (07:49 -0800)
Problem reported by Werner Lemberg in:
http://lists.gnu.org/archive/html/bug-gnulib/2015-03/msg00000.html
* lib/vasnprintf.c (VASNPRINTF): Omit casts that clang objects to.
The casts aren't needed, since the characters in question are ASCII.

ChangeLog
lib/vasnprintf.c

index 86bab1664bf7c53bf92cb49d1afb8ee483395d4b..2d3db72006339318ec452dc623111ad034de3e18 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,11 @@
+2015-03-03  Paul Eggert  <eggert@cs.ucla.edu>
+
+       vasnprintf: pacify clang 3.5.0
+       Problem reported by Werner Lemberg in:
+       http://lists.gnu.org/archive/html/bug-gnulib/2015-03/msg00000.html
+       * lib/vasnprintf.c (VASNPRINTF): Omit casts that clang objects to.
+       The casts aren't needed, since the characters in question are ASCII.
+
 2015-02-24  Paul Eggert  <eggert@cs.ucla.edu>
 
        glob, etc.: port to MSVC v18 on MS-Windows 8.1
index 3797ce1cc3258171c34fedd637230581419e4db2..5254c8cfcbfc4f9145b1565de305585df8f7dd84 100644 (file)
@@ -1886,7 +1886,7 @@ VASNPRINTF (DCHAR_T *resultbuf, size_t *lengthp,
             else
               {
                 do
-                  result[length++] = (unsigned char) *cp++;
+                  result[length++] = *cp++;
                 while (--n > 0);
               }
           }
@@ -4793,7 +4793,7 @@ VASNPRINTF (DCHAR_T *resultbuf, size_t *lengthp,
                           {
                             const FCHAR_T *mp = dp->width_start;
                             do
-                              *fbp++ = (unsigned char) *mp++;
+                              *fbp++ = *mp++;
                             while (--n > 0);
                           }
                       }
@@ -4814,7 +4814,7 @@ VASNPRINTF (DCHAR_T *resultbuf, size_t *lengthp,
                           {
                             const FCHAR_T *mp = dp->precision_start;
                             do
-                              *fbp++ = (unsigned char) *mp++;
+                              *fbp++ = *mp++;
                             while (--n > 0);
                           }
                       }
@@ -5382,7 +5382,7 @@ VASNPRINTF (DCHAR_T *resultbuf, size_t *lengthp,
                             tmpsrc += count;
                             tmpdst += count;
                             for (n = count; n > 0; n--)
-                              *--tmpdst = (unsigned char) *--tmpsrc;
+                              *--tmpdst = *--tmpsrc;
                           }
                       }
 #endif