+2025-04-18 Bruno Haible <bruno@clisp.org>
+
+ getlogin_r tests: Remove xalloc dependency.
+ * tests/test-getlogin.c (main): Don't assume the putenv argument is
+ unmodified.
+ * tests/test-getlogin_r.c: Do not include xalloc.h.
+ (main): Use a static rather than heap storage.
+ * modules/getlogin_r-tests (Depends-on): Remove xalloc.
+ (test_getlogin_LDADD): Remove @LIBINTL@.
+
2025-04-17 Paul Eggert <eggert@cs.ucla.edu>
memset_explicit-tests: pacify -Wuse-after-free
Depends-on:
bool
-xalloc
configure.ac:
Makefile.am:
TESTS += test-getlogin_r
check_PROGRAMS += test-getlogin_r
-test_getlogin_r_LDADD = $(LDADD) @LIBINTL@ $(GETLOGIN_LIB)
+test_getlogin_r_LDADD = $(LDADD) $(GETLOGIN_LIB)
test_getlogin_result (buf, err);
/* Check that getlogin() does not merely return getenv ("LOGNAME"). */
- static char set_LOGNAME[] = "LOGNAME=ygvfibmslhkmvoetbrcegzwydorcke";
- putenv (set_LOGNAME);
- buf = getlogin ();
- ASSERT (!(buf != NULL
- && strcmp (buf, set_LOGNAME + sizeof "LOGNAME") == 0));
+ {
+ static char set_LOGNAME[] = "LOGNAME=ygvfibmslhkmvoetbrcegzwydorcke";
+ putenv (set_LOGNAME);
+ buf = getlogin ();
+ ASSERT (!(buf != NULL
+ && strcmp (buf, "ygvfibmslhkmvoetbrcegzwydorcke") == 0));
+ }
return test_exit_status;
}
SIGNATURE_CHECK (getlogin_r, int, (char *, size_t));
#endif
-#include "xalloc.h"
-
#include "test-getlogin.h"
int
}
/* Check that getlogin_r() does not merely return getenv ("LOGNAME"). */
- putenv (xstrdup ("LOGNAME=ygvfibmslhkmvoetbrcegzwydorcke"));
- err = getlogin_r (buf, sizeof buf);
- ASSERT (!(err == 0 && strcmp (buf, "ygvfibmslhkmvoetbrcegzwydorcke") == 0));
+ {
+ static char set_LOGNAME[] = "LOGNAME=ygvfibmslhkmvoetbrcegzwydorcke";
+ putenv (set_LOGNAME);
+ err = getlogin_r (buf, sizeof buf);
+ ASSERT (!(err == 0 && strcmp (buf, "ygvfibmslhkmvoetbrcegzwydorcke") == 0));
+ }
return test_exit_status;
}