]> Savannah Git Hosting - gnulib.git/commitdiff
manywarnings: add -fno-common
authorJim Meyering <meyering@fb.com>
Fri, 2 Sep 2016 16:16:16 +0000 (09:16 -0700)
committerJim Meyering <meyering@fb.com>
Fri, 2 Sep 2016 17:25:16 +0000 (10:25 -0700)
* m4/manywarnings.m4 (gl_MANYWARN_ALL_GCC): Add -fno-common
to the list.  Quoting the manual, "Compiling with -fno-common is
useful on targets for which it provides better performance, or if
you wish to verify that the program will work on other systems that
always treat uninitialized variable declarations this way [putting
it in the data section]."  If diffutils had been using this sooner,
it would have prevented this duplicate declaration issue:
http://git.sv.gnu.org/cgit/diffutils.git/commit/?id=v3.4-10-gc2dc91f

ChangeLog
m4/manywarnings.m4

index 08365da617e55b96e887ac2c7381f7c548b6c55a..ba3e04817e3d66ccdb49a2d00b379ae45375abaf 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2016-09-02  Jim Meyering  <meyering@fb.com>
+
+       manywarnings: add -fno-common
+       * m4/manywarnings.m4 (gl_MANYWARN_ALL_GCC): Add -fno-common
+       to the list.  Quoting the manual, "Compiling with -fno-common is
+       useful on targets for which it provides better performance, or if
+       you wish to verify that the program will work on other systems that
+       always treat uninitialized variable declarations this way [putting
+       it in the data section]."  If diffutils had been using this sooner,
+       it would have prevented this duplicate declaration issue:
+       http://git.sv.gnu.org/cgit/diffutils.git/commit/?id=v3.4-10-gc2dc91f
+
 2016-08-31  Simon Josefsson  <simon@josefsson.org>
 
        parse-datetime: Fix typo.
index 90823b0acf4145236941f88a35f39274d4b81a39..89fd0ae38e387b9451fb62cb37936ccaefff3686 100644 (file)
@@ -103,6 +103,7 @@ AC_DEFUN([gl_MANYWARN_ALL_GCC],
 
   gl_manywarn_set=
   for gl_manywarn_item in \
+    -fno-common \
     -W \
     -Wabi \
     -Waddress \