]> Savannah Git Hosting - gnulib.git/commitdiff
vasnprintf: fix potential use after free
authorPádraig Brady <P@draigBrady.com>
Sat, 6 Dec 2014 01:14:02 +0000 (01:14 +0000)
committerPádraig Brady <P@draigBrady.com>
Sat, 6 Dec 2014 01:23:15 +0000 (01:23 +0000)
* lib/vasnprintf.c (VASNPRINTF): Fix free-memory read,
flagged by clang-analyzer 3.4.2.

ChangeLog
lib/vasnprintf.c

index 1c4a7ab899e754d1895f88500afea2be0cd5783d..41207ea73e56a16abfe4276cb4d737c7cee532da 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2014-12-06  Pádraig Brady  <P@draigBrady.com>
+
+       vasnprintf: fix potential use after free
+       * lib/vasnprintf.c (VASNPRINTF): Fix free-memory read,
+       flagged by clang-analyzer 3.4.2.
+
 2014-12-05  Pádraig Brady  <P@draigBrady.com>
 
        filevercmp, posixtm: avoid compiler warnings with -O3
index 0484c4ec96b4df957b45166f03ebb6e9f483df18..223be0763a9ebc9e2d00f3aac23aad1f70aa6cda 100644 (file)
@@ -5184,13 +5184,13 @@ VASNPRINTF (DCHAR_T *resultbuf, size_t *lengthp,
                           free (result);
                         if (buf_malloced != NULL)
                           free (buf_malloced);
-                        CLEANUP ();
                         errno =
                           (saved_errno != 0
                            ? saved_errno
                            : (dp->conversion == 'c' || dp->conversion == 's'
                               ? EILSEQ
                               : EINVAL));
+                        CLEANUP ();
                         return NULL;
                       }