]> Savannah Git Hosting - gnulib.git/commitdiff
vasnprintf: Avoid signed/unsigned comparison warning.
authorThien-Thi Nguyen <ttn@gnu.org>
Sun, 31 Aug 2014 08:27:36 +0000 (10:27 +0200)
committerPádraig Brady <P@draigBrady.com>
Sun, 31 Aug 2014 10:30:52 +0000 (11:30 +0100)
* lib/vasnprintf.c (VASNPRINTF): To calculate padding,
compare end addr of generated string w/ maximum end addr.

ChangeLog
lib/vasnprintf.c

index c48ca83054cc5dab92fc24ac64d7dc1eea2de302..c466e87c8cf35efde83124fdd168fa4c25395115 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2014-08-31  Thien-Thi Nguyen  <ttn@gnu.org>  (tiny change)
+
+       vasnprintf: Avoid signed/unsigned comparison warning.
+       * lib/vasnprintf.c (VASNPRINTF): To calculate padding,
+       compare end addr of generated string w/ maximum end addr.
+
 2013-08-30  Mats Erik Andersson  <gnu@gisladisker.se>  (tiny change)
 
        parse-datetime: Avoid pointer difference.
index f2ccc1c9ccd610066960e144c260f5d62aa2c7ad..6ca47ebd0af62daa0a0b59a1365f497d08f4ef53 100644 (file)
@@ -3356,7 +3356,7 @@ VASNPRINTF (DCHAR_T *resultbuf, size_t *lengthp,
                   }
                 /* The generated string now extends from tmp to p, with the
                    zero padding insertion point being at pad_ptr.  */
-                if (has_width && p - tmp < width)
+                if (has_width && p < tmp + width)
                   {
                     size_t pad = width - (p - tmp);
                     DCHAR_T *end = p + pad;