From: Collin Funk Date: Mon, 8 Apr 2024 05:00:48 +0000 (-0700) Subject: gnulib-tool.py: Remove unnecessary conditional. X-Git-Tag: v1.0~146 X-Git-Url: https://gitweb.git.savannah.gnu.org/gitweb/?a=commitdiff_plain;h=0340fb9734c538799368c8a628eb643b0be29d57;p=gnulib.git gnulib-tool.py: Remove unnecessary conditional. * pygnulib/GLModuleSystem.py (GLModuleTable.__getitem__): Don't check if the key is valid twice. --- diff --git a/ChangeLog b/ChangeLog index a6ba2ae992..3beac9b999 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2024-04-08 Collin Funk + + gnulib-tool.py: Remove unnecessary conditional. + * pygnulib/GLModuleSystem.py (GLModuleTable.__getitem__): Don't check if + the key is valid twice. + 2024-04-08 Collin Funk gnulib-tool.py: Remove an unused and incorrect function. diff --git a/pygnulib/GLModuleSystem.py b/pygnulib/GLModuleSystem.py index 3997668538..d3f38c2b66 100644 --- a/pygnulib/GLModuleSystem.py +++ b/pygnulib/GLModuleSystem.py @@ -763,17 +763,16 @@ class GLModuleTable: def __getitem__(self, y: str) -> list[GLModule]: '''x.__getitem__(y) <==> x[y]''' - if y in ['base', 'final', 'main', 'tests', 'avoids']: - if y == 'base': - return self.getBaseModules() - elif y == 'final': - return self.getFinalModules() - elif y == 'main': - return self.getMainModules() - elif y == 'tests': - return self.getTestsModules() - else: # if y == 'avoids' - return self.getAvoids() + if y == 'base': + return self.getBaseModules() + elif y == 'final': + return self.getFinalModules() + elif y == 'main': + return self.getMainModules() + elif y == 'tests': + return self.getTestsModules() + elif y == 'avoids': + return self.getAvoids() else: # if y is not in list raise KeyError('GLModuleTable does not contain key: %s' % repr(y))