From: Paul Eggert Date: Tue, 1 Nov 2016 22:38:59 +0000 (-0700) Subject: futimens: remove FIXME for old Linux kernels X-Git-Tag: v1.0~6571 X-Git-Url: https://gitweb.git.savannah.gnu.org/gitweb/?a=commitdiff_plain;h=35a51f8031317f5571c5338b60b5457fc9a14cc8;p=gnulib.git futimens: remove FIXME for old Linux kernels * m4/futimens.m4 (gl_FUNC_FUTIMENS): Belatedy do a "simplify this in 2012" FIXME, like that for utimensat. --- diff --git a/ChangeLog b/ChangeLog index 999dc0418a..6e578870a5 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,9 @@ 2016-11-01 Paul Eggert + futimens: remove FIXME for old Linux kernels + * m4/futimens.m4 (gl_FUNC_FUTIMENS): Belatedy do a "simplify + this in 2012" FIXME, like that for utimensat. + utimensat: remove FIXME for old Linux kernels * lib/utimensat.c (rpl_utimensat): Update FIXME comment. * m4/utimensat.m4 (gl_FUNC_UTIMENSAT): Belatedy do a "simplify diff --git a/m4/futimens.m4 b/m4/futimens.m4 index 159468cb79..3418d4e052 100644 --- a/m4/futimens.m4 +++ b/m4/futimens.m4 @@ -1,4 +1,4 @@ -# serial 6 +# serial 7 # See if we need to provide futimens replacement. dnl Copyright (C) 2009-2016 Free Software Foundation, Inc. @@ -38,21 +38,11 @@ AC_DEFUN([gl_FUNC_FUTIMENS], if (fstat (fd, &st)) return 6; if (st.st_ctime < st.st_atime) return 7; ]])], -dnl FIXME: simplify this in 2012, when file system bugs are no longer common - [AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[ -#ifdef __linux__ -/* The Linux kernel added futimens in 2.6.22, but has bugs with UTIME_OMIT - in several file systems as recently as 2.6.32. Always replace futimens - to support older kernels. */ -choke me -#endif - ]])], - [gl_cv_func_futimens_works=yes], - [gl_cv_func_futimens_works="needs runtime check"])], + [gl_cv_func_futimens_works=yes], [gl_cv_func_futimens_works=no], - [gl_cv_func_futimens_works="guessing no"]) + [gl_cv_func_futimens_works="guessing yes"]) rm -f conftest.file]) - if test "$gl_cv_func_futimens_works" != yes; then + if test "$gl_cv_func_futimens_works" = no; then REPLACE_FUTIMENS=1 fi fi