From: Martin Kletzander Date: Mon, 4 Jul 2016 07:10:59 +0000 (+0200) Subject: printf-posix: Fix mingw build X-Git-Tag: v1.0~6718 X-Git-Url: https://gitweb.git.savannah.gnu.org/gitweb/?a=commitdiff_plain;h=68b6adebef05670a312fb92b05e7bd089d2ed43a;p=gnulib.git printf-posix: Fix mingw build Commit 54615b95ff238e235e806855efc46a9abad09f2e changed the regular expression for detecting C symbol prefixes but forgot to qoute square brackets in the command line arguments for grep. That way when building with mingw the condition was false although it ought to be true instead. In particular scenarios this led to the following compile error: Cannot export rpl_printf: symbol not found Cannot export rpl_scanf: symbol not found collect2: error: ld returned 1 exit status Fix this by properly quoting square brackets. --- diff --git a/ChangeLog b/ChangeLog index ef332683bb..38c613ca85 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,19 @@ +2016-07-04 Martin Kletzander + + printf-posix: Fix mingw build + Commit 54615b95ff238e235e806855efc46a9abad09f2e changed the regular + expression for detecting C symbol prefixes but forgot to qoute square + brackets in the command line arguments for grep. That way when + building with mingw the condition was false although it ought to be + true instead. In particular scenarios this led to the following + compile error: + + Cannot export rpl_printf: symbol not found + Cannot export rpl_scanf: symbol not found + collect2: error: ld returned 1 exit status + + Fix this by properly quoting square brackets. + 2016-07-03 Paul Eggert mktime: call tzset as per POSIX diff --git a/m4/asm-underscore.m4 b/m4/asm-underscore.m4 index 547dd62d26..feca18db9b 100644 --- a/m4/asm-underscore.m4 +++ b/m4/asm-underscore.m4 @@ -29,7 +29,7 @@ int foo(void) { return 0; } EOF # Look for the assembly language name in the .s file. AC_TRY_COMMAND(${CC-cc} $CFLAGS $CPPFLAGS $gl_c_asm_opt conftest.c) >/dev/null 2>&1 - if LC_ALL=C grep -E '(^|[^a-zA-Z0-9_])_foo([^a-zA-Z0-9_]|$)' conftest.$gl_asmext >/dev/null; then + if LC_ALL=C grep -E '(^|[[^a-zA-Z0-9_]])_foo([[^a-zA-Z0-9_]]|$)' conftest.$gl_asmext >/dev/null; then gl_cv_prog_as_underscore=yes else gl_cv_prog_as_underscore=no