From: Paul Eggert Date: Fri, 9 Jun 2023 18:13:19 +0000 (-0700) Subject: xalloc-die: omit /*extern*/ X-Git-Url: https://gitweb.git.savannah.gnu.org/gitweb/?a=commitdiff_plain;h=986ae8e42fc35e6ffc16d3ee7cc4c645e104d27c;p=gnulib.git xalloc-die: omit /*extern*/ * lib/xalloc.h (xalloc_die): Omit leading "/*extern*/". It complicates syntax checking; see: https://lists.gnu.org/r/bug-gnulib/2023-06/msg00062.html Plus, it’s inconsistent style: the other function declarations in xalloc.h don’t use ‘extern’. (I’m not a fan of using ‘extern’ when it’s just noise, as is the case here.) --- diff --git a/ChangeLog b/ChangeLog index bce2c247d9..150153626c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,13 @@ +2023-06-09 Paul Eggert + + xalloc-die: omit /*extern*/ + * lib/xalloc.h (xalloc_die): Omit leading "/*extern*/". + It complicates syntax checking; see: + https://lists.gnu.org/r/bug-gnulib/2023-06/msg00062.html + Plus, it’s inconsistent style: the other function declarations in + xalloc.h don’t use ‘extern’. (I’m not a fan of using ‘extern’ when + it’s just noise, as is the case here.) + 2023-06-06 Jim Meyering maint.mk: regenerate regex to reflect new functions in xalloc.h diff --git a/lib/xalloc.h b/lib/xalloc.h index 9f4bf8d454..a5e82fb7bc 100644 --- a/lib/xalloc.h +++ b/lib/xalloc.h @@ -1,6 +1,6 @@ /* xalloc.h -- malloc with out-of-memory checking - Copyright (C) 1990-2000, 2003-2004, 2006-2022 Free Software Foundation, Inc. + Copyright (C) 1990-2000, 2003-2004, 2006-2023 Free Software Foundation, Inc. This program is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by @@ -48,7 +48,7 @@ extern "C" { or by using gnulib's xalloc-die module. This is the function to call when one wants the program to die because of a memory allocation failure. */ -/*extern*/ _Noreturn void xalloc_die (void); +_Noreturn void xalloc_die (void); #endif /* GNULIB_XALLOC_DIE */