From: Paul Eggert Date: Sat, 3 Feb 2024 20:05:17 +0000 (-0800) Subject: ctime: fix false positive X-Git-Url: https://gitweb.git.savannah.gnu.org/gitweb/?a=commitdiff_plain;h=b1cddaa01f436cf817a5c413d02d9c5a66619d03;p=gnulib.git ctime: fix false positive Problem reported by Bjarni Ingi Gislason in: https://lists.gnu.org/r/bug-gnulib/2024-02/msg00006.html * lib/time.in.h (ctime): Do not warn about ctime portability, as there is a more serious warning about it crashing, and the two warning directives can cause false alarms. --- diff --git a/ChangeLog b/ChangeLog index 6a646b9063..76f9a47244 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,12 @@ +2024-02-03 Paul Eggert + + ctime: fix false positive + Problem reported by Bjarni Ingi Gislason in: + https://lists.gnu.org/r/bug-gnulib/2024-02/msg00006.html + * lib/time.in.h (ctime): Do not warn about ctime portability, + as there is a more serious warning about it crashing, + and the two warning directives can cause false alarms. + 2024-01-30 Bruno Haible Update copyright year in tests/unictype/*. diff --git a/lib/time.in.h b/lib/time.in.h index ce28f1af25..df99c8abca 100644 --- a/lib/time.in.h +++ b/lib/time.in.h @@ -438,11 +438,7 @@ _GL_CXXALIAS_SYS (ctime, char *, (time_t const *__tp)); _GL_CXXALIASWARN (ctime); # endif # elif defined GNULIB_POSIXCHECK -# undef ctime -# if HAVE_RAW_DECL_CTIME -_GL_WARN_ON_USE (ctime, "ctime has portability problems - " - "use gnulib module ctime for portability"); -# endif +/* No need to warn about portability, as a more serious warning is below. */ # endif /* Convert *TP to a date and time string. See