From: Bruno Haible Date: Mon, 24 Apr 2023 11:56:46 +0000 (+0200) Subject: system-quote: Fix memory overrun bug on native Windows. X-Git-Url: https://gitweb.git.savannah.gnu.org/gitweb/?a=commitdiff_plain;h=bf8b7c93f4f3988af3b414851cbaae2ca8f93b4e;p=gnulib.git system-quote: Fix memory overrun bug on native Windows. * lib/system-quote.c (system_quote): Allocate enough space for the result. --- diff --git a/ChangeLog b/ChangeLog index 700dcd21a2..45453503f9 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2023-04-24 Bruno Haible + + system-quote: Fix memory overrun bug on native Windows. + * lib/system-quote.c (system_quote): Allocate enough space for the + result. + 2023-04-24 Bruno Haible unicodeio tests: Avoid test failures on native Windows. diff --git a/lib/system-quote.c b/lib/system-quote.c index 7ac844830d..bfb93a1454 100644 --- a/lib/system-quote.c +++ b/lib/system-quote.c @@ -1,5 +1,5 @@ /* Quoting for a system command. - Copyright (C) 2012-2022 Free Software Foundation, Inc. + Copyright (C) 2012-2023 Free Software Foundation, Inc. Written by Bruno Haible , 2012. This program is free software: you can redistribute it and/or modify @@ -258,7 +258,7 @@ system_quote (enum system_command_interpreter interpreter, case SCI_SYSTEM: case SCI_WINDOWS_CMD: { - size_t length = system_quote_length (interpreter, string); + size_t length = system_quote_length (interpreter, string) + 1; char *quoted = XNMALLOC (length, char); system_quote_copy (quoted, interpreter, string); return quoted;