From: Jim Meyering Date: Wed, 5 Oct 2016 17:43:09 +0000 (-0700) Subject: long-options: avoid new GCC 7 warning from -Wimplicit-fallthrough X-Git-Tag: v1.0~6616 X-Git-Url: https://gitweb.git.savannah.gnu.org/gitweb/?a=commitdiff_plain;h=d392d4925dd6649ad11b5885a0602d14069f685c;p=gnulib.git long-options: avoid new GCC 7 warning from -Wimplicit-fallthrough * lib/long-options.c (parse_long_options): Add a break statement to avoid this new warning/failure: $ CFLAGS='-O -Werror=implicit-fallthrough' ./gnulib-tool \ --create-testdir --dir=/t/x --with-tests --test long-options ../../gllib/long-options.c: In function ‘parse_long_options’: ../../gllib/long-options.c:66:12: error: this statement may \ fall through [-Werror=implicit-fallthrough] (*usage_func) (EXIT_SUCCESS); ~^~~~~~~~~~~~~~~~~~~~~~~~~~~ --- diff --git a/ChangeLog b/ChangeLog index 7b04177028..ebf9a35d3c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,16 @@ 2016-10-05 Jim Meyering + long-options: avoid new GCC 7 warning from -Wimplicit-fallthrough + * lib/long-options.c (parse_long_options): Add a break statement + to avoid this new warning/failure: + $ CFLAGS='-O -Werror=implicit-fallthrough' ./gnulib-tool \ + --create-testdir --dir=/t/x --with-tests --test long-options + ../../gllib/long-options.c: In function ‘parse_long_options’: + ../../gllib/long-options.c:66:12: error: this statement may \ + fall through [-Werror=implicit-fallthrough] + (*usage_func) (EXIT_SUCCESS); + ~^~~~~~~~~~~~~~~~~~~~~~~~~~~ + utimecmp: avoid new GCC 7 warning from -Wbool-operation Testing this module would fail when using GCC 7 like this: $ CFLAGS='-O -Werror=bool-operation' ./gnulib-tool --create-testdir \ diff --git a/lib/long-options.c b/lib/long-options.c index e694e280d2..ff28e0fd64 100644 --- a/lib/long-options.c +++ b/lib/long-options.c @@ -64,6 +64,7 @@ parse_long_options (int argc, { case 'h': (*usage_func) (EXIT_SUCCESS); + break; case 'v': {