From: Paul Eggert Date: Sun, 8 May 2016 18:38:22 +0000 (-0700) Subject: git-version-gen: avoid undefined shift X-Git-Tag: v1.0~6747 X-Git-Url: https://gitweb.git.savannah.gnu.org/gitweb/?a=commitdiff_plain;h=de37a1ca04a04f16c75ba809452336fb55bcbf98;p=gnulib.git git-version-gen: avoid undefined shift Problem reported by Mosè Giordano in: http://lists.gnu.org/archive/html/bug-gnulib/2016-05/msg00012.html * build-aux/git-version-gen: Avoid undefined behavior if invoked with --prefix or --fallback but without a later argument. While we're at it, omit unnecessary quotes. --- diff --git a/ChangeLog b/ChangeLog index 803a00884f..fe747e52c4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,12 @@ +2016-05-08 Paul Eggert + + git-version-gen: avoid undefined shift + Problem reported by Mosè Giordano in: + http://lists.gnu.org/archive/html/bug-gnulib/2016-05/msg00012.html + * build-aux/git-version-gen: Avoid undefined behavior if invoked + with --prefix or --fallback but without a later argument. While + we're at it, omit unnecessary quotes. + 2016-05-04 Paul Eggert glob: merge glibc changes into lib/glob.c diff --git a/build-aux/git-version-gen b/build-aux/git-version-gen index 6c56147d2c..bd2c4b6b5a 100755 --- a/build-aux/git-version-gen +++ b/build-aux/git-version-gen @@ -1,6 +1,6 @@ #!/bin/sh # Print a version string. -scriptversion=2016-01-11.22; # UTC +scriptversion=2016-05-08.18; # UTC # Copyright (C) 2007-2016 Free Software Foundation, Inc. # @@ -101,8 +101,8 @@ while test $# -gt 0; do case $1 in --help) echo "$usage"; exit 0;; --version) echo "$version"; exit 0;; - --prefix) shift; prefix="$1";; - --fallback) shift; fallback="$1";; + --prefix) shift; prefix=${1?};; + --fallback) shift; fallback=${1?};; -*) echo "$0: Unknown option '$1'." >&2 echo "$0: Try '--help' for more information." >&2