Eric Blake [Fri, 20 May 2011 17:09:53 +0000 (11:09 -0600)]
perror: work around FreeBSD bug
POSIX requires that 'errno = 0; perror ("")' print the same message
as strerror(0), but this failed if we were replacing strerror to work
around the FreeBSD bug of treating 0 as a failure.
The goal here is to _not_ replace perror on glibc, even though
strerror_r has to be replaced, because the strerror_r replacement is
only for the sake of correcting the signature rather than working
around bugs in the handling of any particular errnum value. Recall
that $gl_cv_func_strerror_r_works is only set if the POSIX signature
was detected in the first place.
* m4/perror.m4 (gl_FUNC_PERROR): Also replace perror if strerror_r
is broken. Move AC_LIBOBJ...
* modules/perror (configure.ac): Here.
* doc/posix-functions/perror.texi (perror): Document this.
* tests/test-perror2.c (main): Enhance test.
Eric Blake [Fri, 20 May 2011 16:42:26 +0000 (10:42 -0600)]
test-perror: check for strerror interactions
This uncovered a glibc bug, although not many people check for
perror failures, so for now I'm not working around it.
http://sourceware.org/bugzilla/show_bug.cgi?id=12792
Jim Meyering [Fri, 20 May 2011 09:53:34 +0000 (11:53 +0200)]
maint: replace misused "a" with "an"
* doc/intprops.texi: "a integer"
* doc/regex.texi: "a explanation"
* lib/alignof.h: "a object"
* lib/argmatch.h: "a explanation"
* lib/argp-help.c: "a option" and "a OPTION_DOC"
* lib/stdint.in.h: "a integer"
* lib/userspec.c: "a owner"
* doc/gnulib.texi: Fix "a idea", and reword.
Paul Eggert [Fri, 20 May 2011 02:16:43 +0000 (19:16 -0700)]
intprops-tests: work around HP-UX 11.23 cc bug with constants
* tests/test-intprops.c (VERIFY): New macro.
(main): Use it, instead of verify, to work around the compiler bug; see
<http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00401.html>.
Paul Eggert [Fri, 20 May 2011 02:16:04 +0000 (19:16 -0700)]
intprops: work around IRIX 6.5 cc bug with 0u - 0u + -1
See http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00406.html
* lib/intprops.h (_GL_INT_NEGATE_CONVERT): New macro.
(_GL_INT_SIGNED, _GL_INT_MAXIMUM, _GL_DIVIDE_OVERFLOW):
(_GL_REMAINDER_OVERFLOW): Use it.
Paul Eggert [Fri, 20 May 2011 02:15:19 +0000 (19:15 -0700)]
intprops-tests: revert unsigned part of previous change
* tests/test-intprops.c (UINT_MAX, ULONG_MAX, UINTMAX_MAX, U0, U1):
Remove; they weren't actually needed. All uses of U0 and U1 removed,
and other casts to 'unsigned int' reverted to 'u' suffixes. See
<http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00406.html>.
Eric Blake [Thu, 19 May 2011 19:35:39 +0000 (13:35 -0600)]
strerror_r: guarantee unchanged errno
POSIX guarantees that strerror doesn't change errno on success,
and since we implement strerror by using strerror_r, it makes
sense to make the same guarantee for strerror_r (rather, going
one step further to say that sterror_r does not corrupt errno,
since it returns an error value explicitly).
See also http://austingroupbugs.net/view.php?id=447
* lib/strerror_r.c (strerror_r): Guarantee unchanged errno.
* lib/strerror-impl.h (strerror): Set errno to match strerror_r
failure.
* tests/test-strerror_r.c (main): Enhance test.
Bruno Haible [Thu, 19 May 2011 19:49:01 +0000 (21:49 +0200)]
perror: Avoid clobbering the strerror buffer when possible.
* lib/strerror-impl.h: New file, extracted from lib/strerror.c.
* lib/strerror.c: Include it.
* modules/strerror (Files): Add lib/strerror-impl.h.
* lib/perror.c: Include <stdlib.h>, intprops.h, verify.h.
(my_strerror): New function, defined through lib/strerror-impl.h.
(perror): Use it instead of strerror.
* modules/perror (Files): Add lib/strerror-impl.h.
(Depends-on): Remove strerror. Add intprops, verify, strerror_r-posix.
Bruno Haible [Thu, 19 May 2011 18:57:21 +0000 (20:57 +0200)]
strerror_r: Avoid clobbering the strerror buffer when possible.
* lib/strerror.c: Define _NETBSD_SOURCE. Include <nl_types.h>.
(sys_nerr, sys_errlist): New declarations.
(strerror_r): Be careful not to clobber the strerror buffer on NetBSD,
HP-UX, native Win32, IRIX, and 32-bit Solaris.
* m4/strerror_r.m4 (gl_PREREQ_STRERROR_R): Test whether catgets exists.
Bruno Haible [Thu, 19 May 2011 18:45:59 +0000 (20:45 +0200)]
strerror_r: Fix test failure on mingw.
* m4/strerror_r.m4 (gl_FUNC_STRERROR_R): Don't define
EXTEND_STRERROR_R.
* lib/strerror_r.c (strerror_r): Test the various GNULIB_defined_*
macros from errno.in.h instead.
Eric Blake [Thu, 19 May 2011 16:17:18 +0000 (10:17 -0600)]
strerror: relax test for Solaris
Solaris returns "Error 0" for 0 vs. "Unknown error" for -1; while that
does not quite have the positive connotation that POSIX recommends, it
is distinct enough that we do not need to replace the native strerror
just to pick a better string.
The test is really trying to reject implementations that use the same
string for both 0 and 1 (modulo any %d output of the error number).
* tests/test-strerror.c (main): Permit Solaris behavior.
* tests/test-strerror_r.c (main): Likewise.
Paul Eggert [Thu, 19 May 2011 08:43:17 +0000 (01:43 -0700)]
intprop-tests: port to older and more-pedantic compilers
* modules/intprops-tests (Files): Add tests/macros.h.
* tests/test-intprops.c: Include macros.h.
(TYPE_IS_INTEGER): Use ASSERT, not verify, to test this macro, as
it's no longer documented to expand to an integer constant expression.
(TYPE_SIGNED): Use ASSERT, not verify, to test this macro when the
argument is floating point, as it's no longer documented to expand
to an integer constant expression in that case.
(UINT_MAX, ULONG_MAX, UINTMAX_MAX): Redefine to work around
compiler bugs reported by Bruno Haible. See
<http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00401.html>.
(U0, U1): New constants, to work around the same bugs. Also,
in tests, use e.g., "(unsigned int) 39" rather than "39u".
Paul Eggert [Thu, 19 May 2011 08:36:25 +0000 (01:36 -0700)]
intprops: work around C compiler bugs
* lib/intprops.h (INT_MULTIPLY_RANGE_OVERFLOW): Work around compiler
bug in Sun C 5.11 2010/08/13 and other compilers; see
<http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00401.html>.
Paul Eggert [Thu, 19 May 2011 08:34:14 +0000 (01:34 -0700)]
intprops: TYPE_IS_INTEGER, TYPE_SIGNED not integer constant exprs
* doc/intprops.texi (Integer Type Determination): Fix
documentation for TYPE_IS_INTEGER: it returns an constant
expression, not an integer constant expression. Fix doc for
TYPE_SIGNED: it returns an integer constant expression only if its
argument is an integer type. (TYPE_IS_INTEGER is the same, but is
hardly worth documented that way....)
Eric Blake [Wed, 18 May 2011 19:13:03 +0000 (13:13 -0600)]
fnmatch: avoid compiler warning
Detected on Ubuntu 10.04, where the glibc fnmatch fix is not yet
present; also reproduced via:
$ gl_cv_func_fnmatch_posix=no CFLAGS=-Wall \
./gnulib-tool --with-tests --test fnmatch
In file included from gllib/fnmatch.c:172:0:
gllib/fnmatch_loop.c: In function ‘internal_fnmatch’:
gllib/fnmatch_loop.c:203:28: error: initialization discards qualifiers from pointer target type
gllib/fnmatch_loop.c:204:28: error: initialization discards qualifiers from pointer target type
* lib/fnmatch_loop.c (FCT): Use correct type.
Reported by Matthias Bolte.
Jim Meyering [Tue, 17 May 2011 20:24:59 +0000 (22:24 +0200)]
announce-gen: fail if the NEWS delta is empty
If there's nothing noteworthy in NEWS, then either you forgot
or you shouldn't be releasing.
* build-aux/announce-gen: Die if the NEWS delta is effectively empty.
Paul Eggert [Tue, 17 May 2011 20:07:28 +0000 (13:07 -0700)]
verify: add doc to gnulib manual and fix example
* doc/gnulib.texi (Compile-time Assertions): New node, for 'verify'.
* doc/verify.texi (Compile-time Assertions): Update 'assert' doc.
(Compile-time Assertions): Fix example so it can't overflow.
Eric Blake [Mon, 16 May 2011 23:20:47 +0000 (17:20 -0600)]
inttypes: avoid autoconf warning
I noticed this while updating libvirt to the latest gnulib.
configure.ac:80: warning: AC_REQUIRE: `gl_STDINT_H' was expanded before it was required
gnulib/m4/inttypes.m4:18: gl_INTTYPES_INCOMPLETE is expanded from...
gnulib/m4/inttypes.m4:12: gl_INTTYPES_H is expanded from...
gnulib/m4/gnulib-comp.m4:379: gl_INIT is expanded from...
configure.ac:80: the top level
* m4/inttypes.m4 (gl_INTTYPES_INCOMPLETE): Only expand once.
* m4/stdint.m4 (gl_STDINT_H): Likewise.
Bruno Haible [Mon, 16 May 2011 22:25:35 +0000 (00:25 +0200)]
doc: List the target platforms.
* doc/gnulib-intro.texi (Target Platforms): New section.
* doc/gnulib.texi (Introduction): Update menu.
* README (Portability guidelines): Refer to the new section. Update
statement about oldest supported environment. Remove rationale why
<errno.h>, <string.h>, <stdlib.h> are assumed. Update example of an
unportable C89 function.
Reported by Bastien Roucariès <roucaries.bastien@gmail.com> and
Charles Wilson <cygwin@cwilson.fastmail.fm>. Feedback from Paul Eggert.
James Youngman [Thu, 12 May 2011 21:14:12 +0000 (22:14 +0100)]
fnmatch: add a test for glibc's Bugzilla bug #12378
* m4/fnmatch.m4: Use gnulib's fnmatch if the system fnmatch
doesn't allow the literal matching of a lone "[" (which is
required by POSIX).
* tests/test-fnmatch.c (main): Check that "[/b" matches itself.
* lib/fnmatch_loop.c (FCT): When matching '[' keep track of
beginning and fall back to matching as normal character if the
string ends before the matching ']' is found. This is what POSIX
requires.
Eric Blake [Fri, 13 May 2011 16:26:08 +0000 (10:26 -0600)]
getcwd-lgpl: relax test for FreeBSD
getcwd(NULL, 1) mallocs a larger buffer on BSD, rather than failing
with ERANGE as on glibc. This behavior difference is not worth
coding around, as it is an uncommon use of getcwd in the first place.
Eric Blake [Wed, 11 May 2011 17:21:01 +0000 (11:21 -0600)]
bootstrap: support a prereq of 'rpcgen -' on RHEL5
On RHEL 5, 'rpcgen --version' spews usage to stderr with status 1,
rather than a version string to stdout with status 0. But libvirt
merely requires a prereq of 'rpcgen -' - that is, it must exist,
but need not have a well-behaved --version.
* build-aux/bootstrap (check_versions): When no specific version
is required, merely check that the app produces an exit status
that indicates its existence.
Jim Meyering [Wed, 11 May 2011 08:41:23 +0000 (10:41 +0200)]
maint.mk: adjust previous commit
Change "misc" in names to "undesirable_word_seq".
"misc" is rarely desirable, in a name ;-)
Define and use ignore_undesirable_word_sequence_RE_ properly.
Jim Meyering [Wed, 11 May 2011 08:07:32 +0000 (10:07 +0200)]
maint.mk: improve "can not" detection and generalize rule name
* top/maint.mk (sc_prohibit_misc): Renamed from sc_prohibit_can_not,
since we'll probably add a few more word pairs here.
Use the same technique as in sc_prohibit_doubled_word, so that
we recognize "can not" also when the words are separated by a newline.
Suggested by Eric Blake.
(perl_filename_lineno_text_): Define. Factored out of...
(prohibit_doubled_word_): ...here. Use the new definition.
(prohibit_misc_): New var. Use it here, too.
(prohibit_misc_RE_): New overridable variable.
Eric Blake [Tue, 10 May 2011 21:28:48 +0000 (15:28 -0600)]
fclose: avoid double close race when possible
Calling close(fileno(fp)) prior to fclose(fp) is racy in a
multi-threaded application - some other thread could open a new file,
which is then inadvertently closed by the fclose that we thought
should fail with EBADF. For mingw, this is no worse than the race
already present in close_fd_maybe_socket for calling closesocket()
prior to _close(), but for all other platforms, we might as well be
nice and avoid the race.
* lib/fclose.c (rpl_fclose): Rewrite to avoid double-close race on
all but WINDOWS_SOCKETS.
Eric Blake [Mon, 9 May 2011 22:27:35 +0000 (16:27 -0600)]
openat: reduce syscalls in first probe of /proc
open/access/close is cheaper than open/stat/stat/close.
Use O_DIRECTORY for safety.
* lib/openat-proc.c (openat_proc_name): Require that /proc/self/fd
be a directory. Simplify the probe for .. bugs.
* modules/openat (Depends-on): Drop same-inode.
Reported by Bastien ROUCARIES.
Paul Eggert [Sun, 8 May 2011 19:28:01 +0000 (12:28 -0700)]
intprops: Sun C 5.11 supports __typeof__
* lib/intprops.h (_GL_HAVE___TYPEOF__): New macro, which is set
for either GCC 2 or later, as before, or for Sun C 5.11 or later,
which is new.
(_GL_SIGNED_TYPE_OR_EXPR): Use it.
Jim Meyering [Sun, 8 May 2011 16:13:59 +0000 (18:13 +0200)]
maint.mk: suppress "Entering/Leaving directory" diag in announcement
* top/maint.mk (release-prep): Use make's --no-print-directory
option when generating the announcement. This eliminates the
pesky "make[2]: Entering/Leaving directory" diagnostics in the
generated announcement template.
Paul Eggert [Sat, 7 May 2011 21:29:30 +0000 (14:29 -0700)]
ignore-value, verify: Omit include files from lib_SOURCES.
* modules/ignore-value, modules/verify (Makefile.am):
Don't put ignore-value.h, or verify.h, into lib_SOURCES, as
that leads Automake to duplicate use of am__objects_... variables
in Makefile.in. See
<http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00257.html>.
Eric Blake [Fri, 6 May 2011 19:01:17 +0000 (13:01 -0600)]
fclose: guarantee behavior on seekable stdin
* modules/fclose (Depends-on): Add fflush.
* doc/posix-functions/fclose.texi (fclose): Document this.
* tests/test-fclose.c (main): Make test for this unconditional.
Bruno Haible [Fri, 6 May 2011 18:14:41 +0000 (20:14 +0200)]
fflush, fpurge: Relicense under LGPLv2+.
* modules/fflush (License): Change from LGPLv3+ to LGPLv2+.
* modules/fpurge (License): Likewise.
With permission from Eric Blake and Jim Meyering.
Suggested by Eric Blake.
Jim Meyering [Fri, 6 May 2011 06:09:21 +0000 (08:09 +0200)]
maint.mk: use info-gnu@ as the default only for a stable release
* top/maint.mk: Don't default to info-gnu for alpha or beta releases.
For those, just use $(PACKAGE_BUGREPORT), in which case we don't have
to set the Mail-Followup-To header. Prompted by Reuben Thomas in
http://thread.gmane.org/gmane.comp.lib.gnulib.bugs/26488
Paul Eggert [Fri, 6 May 2011 05:43:18 +0000 (22:43 -0700)]
assert-h: new module, which supports C1X-style static_assert
* lib/assert.in.h, m4/assert_h.m4, modules/assert-h: New files.
* lib/verify.h: Revamp so that this can be copied into assert.h,
while retaining the ability to use it standalone as before.
Rename private identifiers so as not to encroach on the
standard C namespace, since this is now used by assert.h.
(_GL_VERIFY_TYPE): New macro, factoring out differing parts of
the old verify_true.
(_GL_VERIFY_TRUE): New macro, with much of the contents of
the old verify_true. Use _GL_VERIFY_TYPE.
(_GL_VERIFY): New macro, with much of the contents of the old verify.
(static_assert): New macro, if _GL_STATIC_ASSERT_H
is defined and static_assert is not; _GL_STATIC_ASSERT_H is
defined when this file is copied into the replacement assert.h.
(_Static_assert): New macro, if _GL_STATIC_ASSERT_H is defined
and _Static_assert is not built in.
(verify_true, verify): Define only if _GL_STATIC_ASSERT_H is not
defined, and use the new macros mentioned above.
* doc/posix-headers/assert.texi: Document this.
Bruno Haible [Thu, 5 May 2011 22:23:55 +0000 (00:23 +0200)]
fflush, fseeko: Respect rules for use of AC_LIBOBJ.
* m4/fflush.m4 (gl_FUNC_FFLUSH_STDIN): New macro, extracted from
gl_FUNC_FFLUSH.
(gl_FUNC_FFLUSH): Use it.
(gl_REPLACE_FFLUSH): Don't invoke gl_REPLACE_FSEEKO.
* m4/fseeko.m4 (gl_FUNC_FSEEKO): Invoke gl_FUNC_FFLUSH_STDIN and
gl_REPLACE_FSEEKO here.
Bruno Haible [Thu, 5 May 2011 17:31:30 +0000 (19:31 +0200)]
strtoimax, strtoumax: Relicense under LGPL.
* modules/strtoimax (License): Change to LGPL.
* modules/strtoumax (License): Likewise.
With permission from Jim Meyering, Paul Eggert:
<http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00124.html>
<http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00109.html>
Bruno Haible [Thu, 5 May 2011 17:29:48 +0000 (19:29 +0200)]
getgroups: Relicense under LGPL.
* modules/getgroups (License): Change to LGPL.
With permission from Jim Meyering, Paul Eggert, Eric Blake:
<http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00111.html>
<http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00148.html>
<http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00138.html>
Bruno Haible [Thu, 5 May 2011 17:28:21 +0000 (19:28 +0200)]
nanosleep: Relicense under LGPL.
* modules/nanosleep (License): Change to LGPL.
With permission from Jim Meyering, Paul Eggert, Eric Blake, Bruno
Haible:
<http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00111.html>
<http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00148.html>
<http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00138.html>
<http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00131.html>
Bruno Haible [Thu, 5 May 2011 17:25:17 +0000 (19:25 +0200)]
fflush: Relicense under LGPL.
* modules/fflush (License): Change to LGPL.
With permission from Eric Blake, Bruno Haible, Jim Meyering:
<http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00138.html>
<http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00131.html>
<http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00133.html>
Bruno Haible [Thu, 5 May 2011 17:22:52 +0000 (19:22 +0200)]
isfinite: Relicense under LGPL.
* modules/isfinite (License): Change to LGPL.
With permission from Ben Pfaff, Bruno Haible:
<http://lists.gnu.org/archive/html/bug-gnulib/2010-12/msg00185.html>
<http://lists.gnu.org/archive/html/bug-gnulib/2011-05/msg00130.html>
Bruno Haible [Thu, 5 May 2011 17:03:57 +0000 (19:03 +0200)]
signal: Define sighandler_t.
* lib/signal.in.h (sighandler_t): New type.
* m4/signal_h.m4 (gl_SIGNAL_H): Require AC_USE_SYSTEM_EXTENSIONS. Test
whether sighandler_t is defined.
(gl_SIGNAL_H_DEFAULTS): Initialize HAVE_SIGHANDLER_T.
* modules/signal (Depends-on): Add extensions.
(Makefile.am): Substitute HAVE_SIGHANDLER_T.
* doc/posix-headers/signal.texi: Mention the problem with sighandler_t.
Suggested by Markus Steinborn <gnugv_maintainer@yahoo.de>.
Eric Blake [Wed, 4 May 2011 20:26:56 +0000 (14:26 -0600)]
maint: remove useless REPLACE_*_H macros
There are still a few modules, like iconv_h.m4, that still
use older paradigms where GNULIB_POSIXCHECK is unsupported
and where gl_REPLACE_<HEADER>_H is still essential. But since
we are moving away from that style, I see no reason to keep
the idiom for the modules that don't need it.
Bruno Haible [Tue, 3 May 2011 21:32:50 +0000 (23:32 +0200)]
Support for conditional dependencies.
* doc/gnulib.texi (Module description): Document the syntax of
conditional dependencies.
* gnulib-tool: New option --conditional-dependencies.
(func_usage): Document it.
(cond_dependencies): New variable.
(func_get_automake_snippet_conditional,
func_get_automake_snippet_unconditional): New functions, extracted from
func_get_automake_snippet.
(func_get_automake_snippet): Use them.
(sed_first_32_chars): New variable.
(func_module_shellfunc_name): New function.
(func_module_shellvar_name): New function.
(func_module_conditional_name): New function.
(func_uncond_add_module, func_conddep_add_module, func_cond_module_p,
func_cond_module_condition): New functions.
(func_modules_transitive_closure): Add support for conditional
dependencies.
(func_emit_lib_Makefile_am): For a conditional module, enclose the
conditional automake snippet in an automake conditional.
(func_emit_autoconf_snippets): Emit shell functions that contain the
code for conditional modules.
(func_import, func_create_testdir): Update specification.
Eric Blake [Tue, 3 May 2011 21:27:11 +0000 (15:27 -0600)]
test-getaddrinfo: report error information
Clang deduced that if ENABLE_DEBUGGING is undefined, then err
was a dead assignment. But in the EAI_SYSTEM case, we fail
the test, so the output should be unconditional.
* tests/test-getaddrinfo.c (simple): Use err outside of dbprintf.
Jim Meyering [Tue, 3 May 2011 08:31:16 +0000 (10:31 +0200)]
bootstrap: avoid build failure when $GZIP is set
* build-aux/bootstrap (check_versions): Do not treat $GZIP as a
program name. If defined at all, it is supposed to list gzip options.
Reported by Alan Curry in http://debbugs.gnu.org/8609
Reuben Thomas [Tue, 3 May 2011 05:58:45 +0000 (07:58 +0200)]
readme-release: new module with release instructions
* modules/readme-release: New module.
* top/README-release: New file, from coreutils, grep, diffutils.
* MODULES.html.sh (Support for maintaining and releasing): Add it.
Eric Blake [Mon, 2 May 2011 21:00:50 +0000 (15:00 -0600)]
fflush: also replace fclose when fixing fflush
This fixes the fclose failures detected in the previous patch,
but only when the GPL fflush module is also in use. That is
because the need for behavior of resetting seekable input streams
is much less common, and the fix more complex. The LGPLv2+ test
for fclose() in isolation is relaxed to pass if fflush is not
being replaced to cater to input streams.
* modules/fflush (Depends-on): Add fclose.
* m4/fflush.m4 (gl_FUNC_FFLUSH): Also replace fclose.
* lib/fclose.c (rpl_fclose): Don't cause spurious failures on
memstreams with no backing fd.
* doc/posix-functions/fclose.texi (fclose): Document the use of
fflush module to fix the bug.
* tests/test-fclose.c (main): Relax test when fclose is used in
isolation.