From 0ff4d2d5894ec53eb8bc8930266e3e8e93f5b51b Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Tue, 3 Jan 2023 19:48:59 +0100 Subject: [PATCH] ffs: Document Android problem. * doc/posix-functions/ffs.texi: Mention Android problem. * m4/ffs.m4: Update comment. --- ChangeLog | 6 ++++++ doc/posix-functions/ffs.texi | 3 +++ m4/ffs.m4 | 4 ++-- 3 files changed, 11 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 88d5faa592..fc20f7ebe4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2023-01-03 Bruno Haible + + ffs: Document Android problem. + * doc/posix-functions/ffs.texi: Mention Android problem. + * m4/ffs.m4: Update comment. + 2023-01-03 Bruno Haible stdio: Fix error in C++ mode on Android, due to putw. diff --git a/doc/posix-functions/ffs.texi b/doc/posix-functions/ffs.texi index 2e65b2f712..69f897a7f8 100644 --- a/doc/posix-functions/ffs.texi +++ b/doc/posix-functions/ffs.texi @@ -15,4 +15,7 @@ mingw, MSVC 14. Portability problems not fixed by Gnulib: @itemize +@item +This function is only defined as an inline function on some platforms: +Android 13. @end itemize diff --git a/m4/ffs.m4 b/m4/ffs.m4 index 3bc6f8eca8..848fd0aa1f 100644 --- a/m4/ffs.m4 +++ b/m4/ffs.m4 @@ -1,4 +1,4 @@ -# ffs.m4 serial 5 +# ffs.m4 serial 6 dnl Copyright (C) 2011-2023 Free Software Foundation, Inc. dnl This file is free software; the Free Software Foundation dnl gives unlimited permission to copy and/or distribute it, @@ -9,7 +9,7 @@ AC_DEFUN([gl_FUNC_FFS], AC_REQUIRE([gl_STRINGS_H_DEFAULTS]) dnl We can't use AC_CHECK_FUNC here, because ffs() is defined as a - dnl static inline function when compiling for Android 4.2 or older. + dnl static inline function when compiling for Android 13 or older. dnl But require that ffs() is declared; otherwise we may be using dnl the GCC built-in function, which leads to warnings dnl "warning: implicit declaration of function 'ffs'". -- 2.39.5