From 2b49e9e122ea06205c4855ec71df26c4217f15af Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Mon, 26 Oct 2020 16:52:23 -0700 Subject: [PATCH] sys_stat: update comments for S_IRWXUGO, S_IXUGO MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit * lib/sys_stat.in.h (S_IXUGO, S_IRWXUGO): Update comments. Perhaps these macros should be removed, as they’re not in either POSIX or GNU. They could be moved to stat-macros.h, which would be cleaner in some sense. --- ChangeLog | 8 ++++++++ lib/sys_stat.in.h | 4 ++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index bb838bc883..4eb5bcb1dc 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2020-10-26 Paul Eggert + + sys_stat: update comments for S_IRWXUGO, S_IXUGO + * lib/sys_stat.in.h (S_IXUGO, S_IRWXUGO): Update comments. + Perhaps these macros should be removed, as they’re not in either + POSIX or GNU. They could be moved to stat-macros.h, which would + be cleaner in some sense. + 2020-10-25 Bruno Haible ssfmalloc tests: Small tweaks. diff --git a/lib/sys_stat.in.h b/lib/sys_stat.in.h index 2d12610748..2578b48df6 100644 --- a/lib/sys_stat.in.h +++ b/lib/sys_stat.in.h @@ -375,11 +375,11 @@ struct stat # define S_IRWXO (S_IROTH | S_IWOTH | S_IXOTH) #endif -/* S_IXUGO is a common extension to POSIX. */ +/* Although S_IXUGO and S_IRWXUGO are not specified by POSIX and are + not implemented in GNU/Linux, some Gnulib-using apps use the macros. */ #if !S_IXUGO # define S_IXUGO (S_IXUSR | S_IXGRP | S_IXOTH) #endif - #ifndef S_IRWXUGO # define S_IRWXUGO (S_IRWXU | S_IRWXG | S_IRWXO) #endif -- 2.39.5