From 4fed9c82b55b815f6e2afacb88999e403fb3117d Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Tue, 3 Mar 2015 07:48:40 -0800 Subject: [PATCH] vasnprintf: pacify clang 3.5.0 Problem reported by Werner Lemberg in: http://lists.gnu.org/archive/html/bug-gnulib/2015-03/msg00000.html * lib/vasnprintf.c (VASNPRINTF): Omit casts that clang objects to. The casts aren't needed, since the characters in question are ASCII. --- ChangeLog | 8 ++++++++ lib/vasnprintf.c | 8 ++++---- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 86bab1664b..2d3db72006 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,11 @@ +2015-03-03 Paul Eggert + + vasnprintf: pacify clang 3.5.0 + Problem reported by Werner Lemberg in: + http://lists.gnu.org/archive/html/bug-gnulib/2015-03/msg00000.html + * lib/vasnprintf.c (VASNPRINTF): Omit casts that clang objects to. + The casts aren't needed, since the characters in question are ASCII. + 2015-02-24 Paul Eggert glob, etc.: port to MSVC v18 on MS-Windows 8.1 diff --git a/lib/vasnprintf.c b/lib/vasnprintf.c index 3797ce1cc3..5254c8cfcb 100644 --- a/lib/vasnprintf.c +++ b/lib/vasnprintf.c @@ -1886,7 +1886,7 @@ VASNPRINTF (DCHAR_T *resultbuf, size_t *lengthp, else { do - result[length++] = (unsigned char) *cp++; + result[length++] = *cp++; while (--n > 0); } } @@ -4793,7 +4793,7 @@ VASNPRINTF (DCHAR_T *resultbuf, size_t *lengthp, { const FCHAR_T *mp = dp->width_start; do - *fbp++ = (unsigned char) *mp++; + *fbp++ = *mp++; while (--n > 0); } } @@ -4814,7 +4814,7 @@ VASNPRINTF (DCHAR_T *resultbuf, size_t *lengthp, { const FCHAR_T *mp = dp->precision_start; do - *fbp++ = (unsigned char) *mp++; + *fbp++ = *mp++; while (--n > 0); } } @@ -5382,7 +5382,7 @@ VASNPRINTF (DCHAR_T *resultbuf, size_t *lengthp, tmpsrc += count; tmpdst += count; for (n = count; n > 0; n--) - *--tmpdst = (unsigned char) *--tmpsrc; + *--tmpdst = *--tmpsrc; } } #endif -- 2.39.5