From 531fdb6e00bd72920466d419100b4860e36a2c85 Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Sat, 28 Jan 2023 20:22:02 +0100 Subject: [PATCH] Clarify _GL_ATTRIBUTE_NODISCARD code. Reported by Paul Eggert. * m4/gnulib-common.m4 (gl_COMMON_BODY): Add comment regarding _GL_ATTRIBUTE_NODISCARD definition. --- ChangeLog | 7 +++++++ m4/gnulib-common.m4 | 5 ++++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 4c8197821e..c78d93a659 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2023-01-28 Bruno Haible + + Clarify _GL_ATTRIBUTE_NODISCARD code. + Reported by Paul Eggert. + * m4/gnulib-common.m4 (gl_COMMON_BODY): Add comment regarding + _GL_ATTRIBUTE_NODISCARD definition. + 2023-01-28 Bruno Haible unistdio/*printf: Fix negative width handling for %U, %lU, %llU. diff --git a/m4/gnulib-common.m4 b/m4/gnulib-common.m4 index 808efc4ab1..060968dcf0 100644 --- a/m4/gnulib-common.m4 +++ b/m4/gnulib-common.m4 @@ -381,7 +381,10 @@ AC_DEFUN([gl_COMMON_BODY], [ #ifndef _GL_ATTRIBUTE_NODISCARD # if defined __clang__ && defined __cplusplus /* With clang up to 15.0.6 (at least), in C++ mode, [[__nodiscard__]] produces - a warning. */ + a warning. + The 1000 below means a yet unknown threshold. When clang++ version X + starts supporting [[__nodiscard__]] without warning about it, you can + replace the 1000 with X. */ # if __clang_major__ >= 1000 # define _GL_ATTRIBUTE_NODISCARD [[__nodiscard__]] # endif -- 2.39.5