From 53348f290e0046e3a3755932b47abc1339c051f1 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Mon, 8 Feb 2016 18:45:55 -0800 Subject: [PATCH] readdir_r: now obsolescent * doc/posix-functions/readdir_r.texi (readdir_r): Now obsolescent. * lib/mountlist.c (read_file_system_list): Add a FIXME. --- ChangeLog | 6 ++++++ doc/posix-functions/readdir_r.texi | 3 +++ lib/mountlist.c | 2 ++ 3 files changed, 11 insertions(+) diff --git a/ChangeLog b/ChangeLog index 5e473847d8..40bdd23684 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2016-02-08 Paul Eggert + + readdir_r: now obsolescent + * doc/posix-functions/readdir_r.texi (readdir_r): Now obsolescent. + * lib/mountlist.c (read_file_system_list): Add a FIXME. + 2016-02-06 Paul Eggert misc: port better to gcc -fsanitize=address diff --git a/doc/posix-functions/readdir_r.texi b/doc/posix-functions/readdir_r.texi index 0eac1c32d6..d3512c32fa 100644 --- a/doc/posix-functions/readdir_r.texi +++ b/doc/posix-functions/readdir_r.texi @@ -9,6 +9,9 @@ Gnulib module: extensions Portability problems fixed by Gnulib: @itemize @item +This function is planned to be removed from POSIX and to be deprecated +in glibc. Portable applications should use @code{readdir}. +@item This function has an incompatible declaration on some platforms: Solaris 11 2011-11 (when @code{_POSIX_PTHREAD_SEMANTICS} is not defined). @end itemize diff --git a/lib/mountlist.c b/lib/mountlist.c index 1e592d2457..829b31d0d8 100644 --- a/lib/mountlist.c +++ b/lib/mountlist.c @@ -1068,6 +1068,8 @@ read_file_system_list (bool need_fs_type) struct dirent entry; struct dirent *result; + /* FIXME: readdir_r is planned to be withdrawn from POSIX and + marked obsolescent in glibc. Use readdir instead. */ if (readdir_r (dirp, &entry, &result) || result == NULL) break; -- 2.39.5