From 648f4ae7311d1ad00658fc314e1a6c896f47e618 Mon Sep 17 00:00:00 2001 From: Assaf Gordon Date: Wed, 9 Jul 2014 19:18:40 -0400 Subject: [PATCH] announce-gen: avoid perl warnings * build-aux/announce-gen: add two minor checks to avoid "use of uninitialized value" warnings when command-line parameters are missing. --- ChangeLog | 7 +++++++ build-aux/announce-gen | 5 +++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 6c465134aa..02c667681e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +2014-07-10 Assaf Gordon + + announce-gen: avoid perl warnings + * build-aux/announce-gen: add two minor checks to avoid + "use of uninitialized value" warnings when command-line parameters are + missing. + 2014-07-10 Assaf Gordon localename: avoid -Wsuggest-attribute={const,pure} warnings diff --git a/build-aux/announce-gen b/build-aux/announce-gen index db9ed50a78..a3aebf7622 100755 --- a/build-aux/announce-gen +++ b/build-aux/announce-gen @@ -416,14 +416,15 @@ sub get_tool_versions ($$) @url_dir_list or (warn "URL directory name(s) not specified\n"), $fail = 1; - my @tool_list = split ',', $bootstrap_tools; + my @tool_list = split ',', $bootstrap_tools + if $bootstrap_tools; grep (/^gnulib$/, @tool_list) ^ defined $gnulib_version and (warn "when specifying gnulib as a tool, you must also specify\n" . "--gnulib-version=V, where V is the result of running git describe\n" . "in the gnulib source directory.\n"), $fail = 1; - exists $valid_release_types{$release_type} + !$release_type || exists $valid_release_types{$release_type} or (warn "'$release_type': invalid release type\n"), $fail = 1; @ARGV -- 2.39.5