From 8685bf617b93a4658301b7a41360b1d104cd8788 Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Mon, 17 Feb 2025 07:34:23 +0100 Subject: [PATCH] getaddrinfo tests: Make failures more verbose. * tests/test-getaddrinfo.c (simple): Print some info before returning 1. --- ChangeLog | 5 +++++ tests/test-getaddrinfo.c | 22 +++++++++++++++++----- 2 files changed, 22 insertions(+), 5 deletions(-) diff --git a/ChangeLog b/ChangeLog index 3587f070e6..63c367c2e0 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,8 @@ +2025-02-17 Bruno Haible + + getaddrinfo tests: Make failures more verbose. + * tests/test-getaddrinfo.c (simple): Print some info before returning 1. + 2025-02-16 Collin Funk doc: Adjust platforms that define O_CLOEXEC in unistd.h. diff --git a/tests/test-getaddrinfo.c b/tests/test-getaddrinfo.c index 31e999cb0e..4485d7dd10 100644 --- a/tests/test-getaddrinfo.c +++ b/tests/test-getaddrinfo.c @@ -95,11 +95,19 @@ simple (int pass, char const *host, char const *service) dbgprintf ("res %d: %s\n", res, gai_strerror (res)); - if (pass == 3 && ! isdigit (host[0])) - return res != EAI_NONAME; - - if (pass == 4 && ! isdigit (service[0])) - return res != EAI_NONAME; + if ((pass == 3 && ! isdigit (host[0])) + || (pass == 4 && ! isdigit (service[0]))) + { + if (res != EAI_NONAME) + { + fprintf (stderr, + "Test case pass=%d, host=%s, service=%s failed: " + "expected EAI_NONAME, got %d\n", + pass, host, service, res); + return 1; + } + return 0; + } if (res != 0) { @@ -130,6 +138,10 @@ simple (int pass, char const *host, char const *service) if (res == EAI_SYSTEM) fprintf (stderr, "system error: %s\n", strerror (err)); + fprintf (stderr, + "Test case pass=%d, host=%s, service=%s failed: " + "expected 0, got %d\n", + pass, host, service, res); return 1; } -- 2.39.5