From 91688fa1b32963559b5df9b6a59ff27ed29fba81 Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Sun, 30 Mar 2025 16:34:40 +0200 Subject: [PATCH] file-has-acl: Update comments regarding Cygwin. * lib/acl-internal.h (HAVE_ACL_EXTENDED_FILE, acl_extended_file): Add more comments. --- ChangeLog | 6 ++++++ lib/acl-internal.h | 9 +++++++-- 2 files changed, 13 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index 58195260cf..a611d62e87 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2025-03-30 Bruno Haible + + file-has-acl: Update comments regarding Cygwin. + * lib/acl-internal.h (HAVE_ACL_EXTENDED_FILE, acl_extended_file): Add + more comments. + 2025-03-29 Bruno Haible acl-permissions: Update comments regarding NetBSD. diff --git a/lib/acl-internal.h b/lib/acl-internal.h index b32a1cdafd..cb969e9797 100644 --- a/lib/acl-internal.h +++ b/lib/acl-internal.h @@ -118,8 +118,13 @@ rpl_acl_set_fd (int fd, acl_t acl) # endif /* Linux-specific */ -/* Cygwin >= 2.5 implements this function, but it returns 1 for all - directories, thus is unusable. */ +/* Cygwin >= 2.5 implements acl_extended_file(), but it returns 1 for nearly all + directories — for reasons explained in + —, thus is + unusable. For the user, 'ls' should not print a '+' sign, indicating the + presence of an ACL, for 99,9% of the files; this would not be useful. + Therefore, on Cygwin, we ignore the acl_extended_file function and instead + use our own acl_access_nontrivial function. */ # if !defined HAVE_ACL_EXTENDED_FILE || defined __CYGWIN__ # undef HAVE_ACL_EXTENDED_FILE # define HAVE_ACL_EXTENDED_FILE false -- 2.39.5