From 92e048ee346d70bb63d79b9f9e12d2227d7f6ae6 Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Fri, 13 Jan 2023 08:51:10 +0100 Subject: [PATCH] qcopy-acl: Avoid autoconf warning. * m4/xattr.m4 (gl_FUNC_XATTR): Provide a description in AC_DEFINE. Also, protect against unsafe use of a configure option value. --- ChangeLog | 6 ++++++ m4/xattr.m4 | 9 +++++---- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 5fab6a279c..1ff605c36a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2023-01-13 Bruno Haible + + qcopy-acl: Avoid autoconf warning. + * m4/xattr.m4 (gl_FUNC_XATTR): Provide a description in AC_DEFINE. + Also, protect against unsafe use of a configure option value. + 2023-01-12 Ondrej Valousek qcopy-acl: Optimize copying of ACLs by directly copying the attributes. diff --git a/m4/xattr.m4 b/m4/xattr.m4 index 6efdfa475a..5cbfc86002 100644 --- a/m4/xattr.m4 +++ b/m4/xattr.m4 @@ -1,5 +1,5 @@ # xattr.m4 - check for Extended Attributes (Linux) -# serial 4 +# serial 5 # Copyright (C) 2003-2021 Free Software Foundation, Inc. # This file is free software; the Free Software Foundation @@ -16,7 +16,7 @@ AC_DEFUN([gl_FUNC_XATTR], LIB_XATTR= AC_SUBST([LIB_XATTR]) - if test "$use_xattr" = "yes"; then + if test "$use_xattr" = yes; then AC_CHECK_HEADERS([attr/error_context.h attr/libattr.h]) use_xattr=no if test "$ac_cv_header_attr_libattr_h" = yes \ @@ -36,7 +36,8 @@ AC_DEFUN([gl_FUNC_XATTR], AC_MSG_WARN([AC_PACKAGE_NAME will be built without xattr support.]) fi fi - if test $use_xattr = yes; then - AC_DEFINE_UNQUOTED([USE_XATTR], 1) + if test "$use_xattr" = yes; then + AC_DEFINE([USE_XATTR], [1], + [Define to 1 to use the Linux extended attributes library.]) fi ]) -- 2.39.5