From 968988975696de692623bbde066d9048dc02d828 Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Wed, 27 May 2020 20:01:30 +0200 Subject: [PATCH] login_tty: Make more robust in multithreaded applications. * lib/login_tty.c (login_tty): Pass an O_CLOEXEC flag to open(). * modules/login_tty (Depends-on): Add 'open'. --- ChangeLog | 6 ++++++ lib/login_tty.c | 2 +- modules/login_tty | 1 + 3 files changed, 8 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 906adffe0f..b034e30a6a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2020-05-28 Bruno Haible + + login_tty: Make more robust in multithreaded applications. + * lib/login_tty.c (login_tty): Pass an O_CLOEXEC flag to open(). + * modules/login_tty (Depends-on): Add 'open'. + 2020-05-28 Bruno Haible javacomp: Make more robust in multithreaded applications. diff --git a/lib/login_tty.c b/lib/login_tty.c index 4dfd263c90..581c27670b 100644 --- a/lib/login_tty.c +++ b/lib/login_tty.c @@ -55,7 +55,7 @@ login_tty (int slave_fd) slave_name = ttyname (slave_fd); if (slave_name == NULL) return -1; - dummy_fd = open (slave_name, O_RDWR); + dummy_fd = open (slave_name, O_RDWR | O_CLOEXEC); if (dummy_fd < 0) return -1; close (dummy_fd); diff --git a/modules/login_tty b/modules/login_tty index 59e5e9b2ab..551691e2c5 100644 --- a/modules/login_tty +++ b/modules/login_tty @@ -9,6 +9,7 @@ m4/pty.m4 Depends-on: pty sys_ioctl +open [test $ac_cv_func_login_tty = no] configure.ac: gl_FUNC_LOGIN_TTY -- 2.39.5