From 98aa8776dd2b510b7f777870fb76b17fd88abbef Mon Sep 17 00:00:00 2001 From: =?utf8?q?P=C3=A1draig=20Brady?=
Date: Tue, 2 Jun 2015 00:53:48 +0100 Subject: [PATCH] file-has-acl: fix build on Mac OS X 10 This reverts commit f1b37e3a which doesn't work on Mac OS X >= 10.4 which has an incompatible 6 parameter getxattr() call. * doc/glibc-functions/getxattr.texi: Mention the divergent getxattr() call on Mac OS X >= 10.4. * doc/glibc-functions/fgetxattr.texi: Likewise. * lib/file-has-acl.c: Revert to more complete combined check. * m4/acl.m4 (gl_FILE_HAS_ACL): Likewise. Reported by Jack Howarth. --- ChangeLog | 12 ++++++++++++ doc/glibc-functions/fgetxattr.texi | 3 +++ doc/glibc-functions/getxattr.texi | 3 +++ lib/file-has-acl.c | 15 ++------------- m4/acl.m4 | 24 +++++++++++++++++++----- 5 files changed, 39 insertions(+), 18 deletions(-) diff --git a/ChangeLog b/ChangeLog index 25dec08b77..2b922ceb6c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,15 @@ +2015-06-02 Pádraig Brady
+ + file-has-acl: fix build on Mac OS X 10 + This reverts commit f1b37e3a which doesn't work on Mac OS X >= 10.4 + which has an incompatible 6 parameter getxattr() call. + * doc/glibc-functions/getxattr.texi: Mention the divergent getxattr() + call on Mac OS X >= 10.4. + * doc/glibc-functions/fgetxattr.texi: Likewise. + * lib/file-has-acl.c: Revert to more complete combined check. + * m4/acl.m4 (gl_FILE_HAS_ACL): Likewise. + Reported by Jack Howarth. + 2015-06-02 Pádraig Brady
prefix-gnulib-mk: remove no longer needed special case
diff --git a/doc/glibc-functions/fgetxattr.texi b/doc/glibc-functions/fgetxattr.texi
index 0fc9bac36a..0fb458f347 100644
--- a/doc/glibc-functions/fgetxattr.texi
+++ b/doc/glibc-functions/fgetxattr.texi
@@ -14,4 +14,7 @@ Portability problems not fixed by Gnulib:
This function is missing on many non-glibc platforms:
Mac OS X 10.3, FreeBSD 6.0, NetBSD 5.0, OpenBSD 3.8, Minix 3.1.8, AIX 5.1, HP-UX 11,
IRIX 6.5, OSF/1 5.1, Solaris 11 2011-11, Cygwin 1.5.x, mingw, MSVC 9, Interix 3.5, BeOS.
+@item
+This function has extra @code{offset} and @code{options} parameters:
+Mac OS X 10.4
@end itemize
diff --git a/doc/glibc-functions/getxattr.texi b/doc/glibc-functions/getxattr.texi
index f206d25332..51ac784a66 100644
--- a/doc/glibc-functions/getxattr.texi
+++ b/doc/glibc-functions/getxattr.texi
@@ -14,4 +14,7 @@ Portability problems not fixed by Gnulib:
This function is missing on many non-glibc platforms:
Mac OS X 10.3, FreeBSD 6.0, NetBSD 5.0, OpenBSD 3.8, Minix 3.1.8, AIX 5.1, HP-UX 11,
IRIX 6.5, OSF/1 5.1, Solaris 11 2011-11, Cygwin 1.5.x, mingw, MSVC 9, Interix 3.5, BeOS.
+@item
+This function has extra @code{offset} and @code{options} parameters:
+Mac OS X 10.4
@end itemize
diff --git a/lib/file-has-acl.c b/lib/file-has-acl.c
index e1871176c0..7e26c53c15 100644
--- a/lib/file-has-acl.c
+++ b/lib/file-has-acl.c
@@ -29,11 +29,8 @@
#include "acl-internal.h"
-#if HAVE_SYS_XATTR_H
+#if GETXATTR_WITH_POSIX_ACLS
# include