From b82b3835323296a1d321d67ff48bc0fa68edc7e8 Mon Sep 17 00:00:00 2001 From: Bruno Haible Date: Tue, 16 May 2017 21:29:32 +0200 Subject: [PATCH] javacomp: Fix handle leak. Found by Coverity. * lib/javacomp.c (get_classfile_version): Close fd before returning. --- ChangeLog | 6 ++++++ lib/javacomp.c | 5 ++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/ChangeLog b/ChangeLog index 0fa2ac6ba0..932383e064 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2017-05-16 Bruno Haible + + javacomp: Fix handle leak. + Found by Coverity. + * lib/javacomp.c (get_classfile_version): Close fd before returning. + 2017-05-16 Bruno Haible relocate: Make it easier to reclaim allocated memory. diff --git a/lib/javacomp.c b/lib/javacomp.c index fe15b2c732..3d7d457b2e 100644 --- a/lib/javacomp.c +++ b/lib/javacomp.c @@ -525,7 +525,10 @@ get_classfile_version (const char *compiled_file_name) /* Verify the class file signature. */ if (header[0] == 0xCA && header[1] == 0xFE && header[2] == 0xBA && header[3] == 0xBE) - return header[7]; + { + close (fd); + return header[7]; + } } close (fd); } -- 2.39.5