From bf8e658ffadb95d444f56d222d04c9af955af765 Mon Sep 17 00:00:00 2001 From: Jim Meyering Date: Fri, 2 Sep 2016 09:16:16 -0700 Subject: [PATCH] manywarnings: add -fno-common * m4/manywarnings.m4 (gl_MANYWARN_ALL_GCC): Add -fno-common to the list. Quoting the manual, "Compiling with -fno-common is useful on targets for which it provides better performance, or if you wish to verify that the program will work on other systems that always treat uninitialized variable declarations this way [putting it in the data section]." If diffutils had been using this sooner, it would have prevented this duplicate declaration issue: http://git.sv.gnu.org/cgit/diffutils.git/commit/?id=v3.4-10-gc2dc91f --- ChangeLog | 12 ++++++++++++ m4/manywarnings.m4 | 1 + 2 files changed, 13 insertions(+) diff --git a/ChangeLog b/ChangeLog index 08365da617..ba3e04817e 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,15 @@ +2016-09-02 Jim Meyering + + manywarnings: add -fno-common + * m4/manywarnings.m4 (gl_MANYWARN_ALL_GCC): Add -fno-common + to the list. Quoting the manual, "Compiling with -fno-common is + useful on targets for which it provides better performance, or if + you wish to verify that the program will work on other systems that + always treat uninitialized variable declarations this way [putting + it in the data section]." If diffutils had been using this sooner, + it would have prevented this duplicate declaration issue: + http://git.sv.gnu.org/cgit/diffutils.git/commit/?id=v3.4-10-gc2dc91f + 2016-08-31 Simon Josefsson parse-datetime: Fix typo. diff --git a/m4/manywarnings.m4 b/m4/manywarnings.m4 index 90823b0acf..89fd0ae38e 100644 --- a/m4/manywarnings.m4 +++ b/m4/manywarnings.m4 @@ -103,6 +103,7 @@ AC_DEFUN([gl_MANYWARN_ALL_GCC], gl_manywarn_set= for gl_manywarn_item in \ + -fno-common \ -W \ -Wabi \ -Waddress \ -- 2.39.5